Let --yjit-dump-disasm=all dump ocb code as well #6309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximecb
reviewed
Sep 1, 2022
maximecb
reviewed
Sep 1, 2022
Contributor
|
Tried this out locally and everything worked well for me. Great addition |
* Add a None Option to DumpDisasm * Update yjit/src/asm/mod.rs Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
k0kubun
requested review from
jimmyhmiller and
maximecb
and removed request for
jimmyhmiller
maximecb
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm debugging a SEGV that seems to be caused inside an outlined cb. For that, I thought it'd be useful to have an option that dumps outlined cb code as well. It works as follows:
--yjit-dump-disasm: Dump only inlined cb--yjit-dump-disasm=all: Dump both inlined and outlined cbscc: @jimmyhmiller