Skip to content

Fix memory leak in the parser#8555

Merged
peterzhu2118 merged 1 commit intoruby:masterfrom
peterzhu2118:nodes-mem-leak
Sep 29, 2023
Merged

Fix memory leak in the parser#8555
peterzhu2118 merged 1 commit intoruby:masterfrom
peterzhu2118:nodes-mem-leak

Conversation

@peterzhu2118
Copy link
Copy Markdown
Member

Reproduction script:

require "ripper"

10.times do
  20_000.times do
    Ripper.parse("")
  end

  puts `ps -o rss= -p #{$$}`
end

Before:

28032
34432
40704
47232
53632
60032
66432
72832
79232
85632

After:

21760
21760
21760
21760
21760
21760
21760
21760
21760
21760

Reproduction script:

```
require "ripper"

10.times do
  20_000.times do
    Ripper.parse("")
  end

  puts `ps -o rss= -p #{$$}`
end
```

Before:

```
28032
34432
40704
47232
53632
60032
66432
72832
79232
85632
```

After:

```
21760
21760
21760
21760
21760
21760
21760
21760
21760
21760
```
@peterzhu2118 peterzhu2118 merged commit 97564dd into ruby:master Sep 29, 2023
@peterzhu2118 peterzhu2118 deleted the nodes-mem-leak branch September 29, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant