Fix memory leak in the parser#8555
Merged
peterzhu2118 merged 1 commit intoruby:masterfrom Sep 29, 2023
Merged
Conversation
Reproduction script:
```
require "ripper"
10.times do
20_000.times do
Ripper.parse("")
end
puts `ps -o rss= -p #{$$}`
end
```
Before:
```
28032
34432
40704
47232
53632
60032
66432
72832
79232
85632
```
After:
```
21760
21760
21760
21760
21760
21760
21760
21760
21760
21760
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction script:
Before:
After: