Skip to content

Remove paths-ignore from required status checks#8646

Merged
k0kubun merged 1 commit intoruby:masterfrom
k0kubun:remove-paths-ignore
Oct 13, 2023
Merged

Remove paths-ignore from required status checks#8646
k0kubun merged 1 commit intoruby:masterfrom
k0kubun:remove-paths-ignore

Conversation

@k0kubun
Copy link
Copy Markdown
Member

@k0kubun k0kubun commented Oct 12, 2023

I'm going to add a few CI jobs to required status check of master branch.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

For this reason you should not use path or branch filtering to skip workflow runs if the workflow is required.

This PR removes paths-ignore from those jobs since GitHub recommends to remove it from jobs used for required status checks.

@k0kubun k0kubun marked this pull request as ready for review October 13, 2023 00:05
@k0kubun k0kubun enabled auto-merge (squash) October 13, 2023 00:05
@k0kubun k0kubun merged commit 842d9c0 into ruby:master Oct 13, 2023
@k0kubun k0kubun deleted the remove-paths-ignore branch October 13, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant