remove_instance_variable: Handle running out of shapes#8811
Merged
byroot merged 1 commit intoruby:masterfrom Nov 1, 2023
Merged
remove_instance_variable: Handle running out of shapes#8811byroot merged 1 commit intoruby:masterfrom
byroot merged 1 commit intoruby:masterfrom
Conversation
casperisfine
force-pushed
the
out-of-shape-remove-ivar
branch
2 times, most recently
from
e771a83 to
f6b83cb
Compare
`remove_shape_recursive` wasn't considering that if we run out of shapes, it might have to transition to SHAPE_TOO_COMPLEX. When this happens, we now return with an error and the caller initiates the evacuation.
auto-merge was automatically disabled
November 1, 2023 13:09
Head branch was pushed to by a user without write access
casperisfine
force-pushed
the
out-of-shape-remove-ivar
branch
from
f6b83cb to
9b45727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_shape_recursivewasn't considering that if we run out of shapes, it might have to transition to SHAPE_TOO_COMPLEX.When this happens, we now return with an error and the caller initiates the evacuation.