Skip to content

Conversation

@st0012
Copy link
Member

@st0012 st0012 commented Dec 12, 2024

Motivation

  • IRB has its own documentation in the project readme and https://ruby.github.io/irb/ already.
  • As a tool, its internal implementation details are not relevant to the user.
  • Excluding it from the documentation generation reduces the size of the generated documentation and makes search results more relevant.

Implementation

The .rdoc_options change will exclude IRB from docs.ruby-lang.org/en's documentation generation. And since IRB is not included anymore, the lib/irb/.document is obsolete so I deleted it (which was manually added in the past, not synced from ruby/irb).

I also checked the there are no references to IRB so it should not break any links.

- IRB has its own documentation in the project readme and https://ruby.github.io/irb/ already.
- As a tool, its internal implementation details are not relevant to the user.
- Excluding it from the documentation generation reduces the size of the generated documentation
  and makes search results more relevant.

I also checked the there are no references to IRB so it should not break any links.
@st0012 st0012 changed the title Exclude irb from documentation generation [DOC] Exclude irb from documentation generation Dec 12, 2024
@hsbt hsbt added the Documentation Improvements to documentation. label Dec 16, 2024
@tompng
Copy link
Member

tompng commented Dec 16, 2024

It depends on the policy of ruby/ruby's document, but I think this change makes sense.

I think having only a single document URL is less confusing. Some default gem's document will be removed from docs.ruby-lang.org when it become a bundled gem, so the standalone document deployed in each gem will last longer.

@jeremyevans jeremyevans merged commit cf71186 into ruby:master Dec 16, 2024
44 checks passed
@st0012 st0012 deleted the exclude-irb-from-docs branch December 20, 2024 20:17
st0012 added a commit to Shopify/ruby that referenced this pull request Dec 20, 2024
Follow-up to ruby#12325

Since we're not generating IRB documentation, we don't need to sync
its `doc/` folder and keep the previous content.
tompng pushed a commit that referenced this pull request Jan 2, 2025
Follow-up to #12325

Since we're not generating IRB documentation, we don't need to sync
its `doc/` folder and keep the previous content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants