Fix setting method visibility on method wrapped with prepend #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
force-pushed
the
fix-set-wrapped-method-visibility
branch
from
4dcfce1 to
76a4a66
Compare
dylanahsmith
commented
Mar 8, 2018
| private :wrapped | ||
| end | ||
|
|
||
| klass.new.wrapped.should == 2 |
Contributor
Author
There was a problem hiding this comment.
Previously this failed with
NoMethodError: super: no superclass method `wrapped' for #<#<Class:0x00007fa541046210>:0x00007fa5410460f8>
because it was adding a method that called super which is meant for the case where an ancestor defines the method rather than when it is defined in a prepended module.
dylanahsmith
force-pushed
the
fix-set-wrapped-method-visibility
branch
from
76a4a66 to
31956b3
Compare
Ignore prepended modules when looking for already defined methods on a class to set the visibility on.
dylanahsmith
force-pushed
the
fix-set-wrapped-method-visibility
branch
from
31956b3 to
b92a89a
Compare
matzbot
pushed a commit
that referenced
this pull request
Mar 20, 2018
Fix setting method visibility on method wrapped with prepend Ignore prepended modules when looking for already defined methods on a class to set the visibility on. [Fix GH-1834] From: Dylan Thacker-Smith <Dylan.Smith@shopify.com> git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matzbot
pushed a commit
that referenced
this pull request
Mar 25, 2018
Fix setting method visibility on method wrapped with prepend Ignore prepended modules when looking for already defined methods on a class to set the visibility on. [Fix GH-1834] From: Dylan Thacker-Smith <Dylan.Smith@shopify.com> git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matzbot
pushed a commit
that referenced
this pull request
Mar 28, 2018
Fix setting method visibility on method wrapped with prepend Ignore prepended modules when looking for already defined methods on a class to set the visibility on. [Fix GH-1834] From: Dylan Thacker-Smith <Dylan.Smith@shopify.com> git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore prepended modules when looking for already defined methods on a
class to set the visibility on.