Allow specification of a servername to use for SNI and hostname verification when using Net::HTTP #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any blockers for this to get merged in? |
JackOfMostTrades
force-pushed
the
http-allow-servername
branch
3 times, most recently
from
bef0aba to
722910b
Compare
…ication when using Net::HTTP.
JackOfMostTrades
force-pushed
the
http-allow-servername
branch
from
631c25f to
8540133
Compare
|
After a little bit of fighting with git, I've rebased this PR over the latest master revision. |
hsbt
pushed a commit
to ruby/net-http
that referenced
this pull request
Feb 21, 2020
to replace the address for TCP/IP connection [Feature #5180] There're 3 layers of hostname: * host address for TCP/IP * TLS server name * HTTP Host header value To test DNS round robin or check server certificate from server local, people sometimes want to connect server with given IP address but keep TLS server name and HTTP Host header value. closes [Feature #15215] closes ruby/ruby#1893 closes ruby/ruby#1977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same option and the same semantics that node.js provides via the "servername" attribute, or that golang provides via the "ServerName" option.