Proposal: Enable refinements to #method_missing
#2036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Dec 3, 2018
spec/ruby/core/module/refine_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| ruby_version_is "2.6" do |
There was a problem hiding this comment.
I have no idea how ruby_version_is works, but I think this test needs to apply to all future Rubies.
Suggested change
| ruby_version_is "2.6" do | |
| ruby_version_is "2.6"..."" do |
There was a problem hiding this comment.
Thanks for comment.
Probably it is judged with 2.6 or higher.
ruby/spec/mspec/lib/mspec/guards/version.rb
Lines 26 to 32 in 30c4b64
There was a problem hiding this comment.
Right, ruby_version_is "2.6" is correct.
It's a bit confusing, I know.
I'm thinking to let "2.6"..."" work at least.
|
It seems to have a conflict now. Could you rebase this from master? |
|
Close because it was rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.