- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.5k
Make it as clear as possible that RubyVM is MRI-specific and only exists on MRI #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
         eregon
  
      
      
      commented
      
            eregon
  
      
      
      commented
        Apr 7, 2019 
      
    
  
- See https://bugs.ruby-lang.org/issues/15743.
- Use "CRuby VM" instead of "Ruby VM" for clarity.
… on MRI * See [Bug #15743]. * Use "CRuby VM" instead of "Ruby VM" for clarity.
| Why are you using both "MRI" and "CRuby"? How do you distinguish their usages? | 
| Ah, "Ruby VM" -> "CRuby VM", but "MRI" by default. Maybe I understood. | 
| I've heard of "MRI", "CRuby", and "Ruby VM", but I think I've never seen "CRuby VM". While adding "MRI specific" descriptions looks good, I don't think it's a good idea to introduce a new confusing terminology "CRuby VM" to our source code as long as the similar terminology "Ruby VM" exists as a constant name  | 
| @k0kubun I used  
 
 OK, let's try to find something else. Maybe for  | 
| @k0kubun I pushed 2 commits to avoid "CRuby VM", can you take a look? (I'll squash the commits when committing of course). | 
|  | ||
| /*! | ||
| * Initializes the Ruby VM and builtin libraries. | ||
| * Initializes the VM and builtin libraries. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped Ruby because it's clear from the function name, and just VM is used in other cases as well such as ruby_finalize and ruby_cleanup.
| 
 The only concern I have is that the similar terminology "Ruby VM" exists. So I would be completely fine with the original change b5e6a1d if  
 TBH I don't have a strong preference on the naming of  For describing "Ruby VM", a7111cb looks better. 
 In that sense, the current pull request (at bacf54d) looks good to me. Thank you for your attention to my comment :) | 
| It seems to have a conflict now. Could you rebase this from master? | 
| I fixed the conflict. Let's the current one and improve it afterwards as needed. |