Revert nil error and adding deprecation message #2637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
This is great! Thank you so much for working on it @kachick
| /backref/ =~ 'backref' | ||
| # must match here, but not in a separate method, e.g., assert_send, | ||
| # to check if $~ is affected or not. | ||
| assert_equal(false, //.match?(nil)) |
There was a problem hiding this comment.
Should we assert the warning?
There was a problem hiding this comment.
It's already checked in specs above.
eugeneius
reviewed
Nov 2, 2019
kachick
added a commit
to kachick/ruby
that referenced
this pull request
Nov 3, 2019
… an error:Update re.c ruby#2637 (comment) Co-Authored-By: Eugene Kenny <elkenny@gmail.com>
kachick
force-pushed
the
deprecation-match-with-nil
branch
from
bb7f955 to
d20d9ce
Compare
|
Merged and NEWS entry updated in fbacfe6, thanks! |
|
Thank you! |
eregon
pushed a commit
to ruby/spec
that referenced
this pull request
Nov 30, 2019
headius
pushed a commit
to headius/spec
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://bugs.ruby-lang.org/issues/13083
This revert #1506 and warns for now.
@rafaelfranca How about this?