Skip to content

[PRISM] Correctly parse non-base 10 integers in Prism #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jemmaissroff merged 1 commit into from
Dec 13, 2023
Merged

[PRISM] Correctly parse non-base 10 integers in Prism #9205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions prism_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ pm_iseq_new_with_opt(pm_scope_node_t *scope_node, pm_parser_t *parser, VALUE nam
static VALUE
parse_integer(const pm_integer_node_t *node)
{
const char *start = (const char *) node->base.location.start;
const char *end = (const char *) node->base.location.end;
char *start = (char *) node->base.location.start;
char *end = (char *) node->base.location.end;

size_t length = end - start;
int base = -10;
Expand All @@ -101,7 +101,7 @@ parse_integer(const pm_integer_node_t *node)
rb_bug("Unexpected integer base");
}

return rb_int_parse_cstr(start, length, NULL, NULL, base, RB_INT_PARSE_DEFAULT);
return rb_int_parse_cstr(start, length, &end, NULL, base, RB_INT_PARSE_DEFAULT);
}

static VALUE
Expand Down
1 change: 1 addition & 0 deletions test/ruby/test_compile_prism.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def test_IntegerNode
assert_prism_eval("0b10")
assert_prism_eval("0o10")
assert_prism_eval("010")
assert_prism_eval("(0o00)")
end

def test_NilNode
Expand Down