Fix handling RDoc::Servlet rename to RDoc::RI::Servlet#14
Merged
hsbt merged 1 commit intoruby:masterfrom May 8, 2026
Merged
Conversation
Member
This commit fixes the following error in Ruby 4.1.0dev. gem_server.rb ``` require 'rubygems/server' gem_server = Gem::Server.new Gem.dir, 8089, false gem_server.run ``` ``` $ ruby gem_server.rb Server started at http://0.0.0.0:8089 Server started at http://[::]:8089 /home/jaruga/.local/ruby-4.1.0-debug-7d4941d3e1-openssl-4.1.0-5e32b3e3fa/lib/ruby/gems/4.1.0+1/gems/rubygems-server-0.3.0/lib/rubygems/server.rb:825:in 'Gem::Server#run': uninitialized constant RDoc::Servlet (NameError) @server.mount '/doc_root', RDoc::Servlet, '/doc_root' ^^^^^^^^^ Did you mean? RDoc::Server from gem_server.rb:4:in '<main>' ``` Because ruby/rdoc renamed the `RDoc::Servlet` to `RDoc::RI::Servlet` at the following commit. ruby/rdoc@3c6f5f6
b2a4a5e to
39bf0e1
Compare
Member
Author
@hsbt Thank you for working on this PR. I rebasd the PR on the current master branch, and tested the above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #12.
I tested in the cases Ruby 4.1 dev with
RDoc::RI::Servletand Ruby 4.0 withRDoc::Servlet.This commit fixes the following error in Ruby 4.1.0dev.
bin/gem_server.rb
Because ruby/rdoc renamed the
RDoc::ServlettoRDoc::RI::Servletat the following commit.ruby/rdoc@3c6f5f6