Remove old workaround for non-git environments#3980
Merged
deivid-rodriguez merged 1 commit intomasterfrom Oct 2, 2020
Merged
Conversation
deivid-rodriguez
force-pushed
the
no_bundler_gemspec_rewrite
branch
from
b1f383a to
ed5483d
Compare
I noticed that running `ruby setup.rb` was rewriting the `bundler.gemspec` when I run it on Windows on a shared folder and noticed that all line feeds had been rewritten. This is no longer necessary since we no longer use `git` in bundler's gemspec.
deivid-rodriguez
force-pushed
the
no_bundler_gemspec_rewrite
branch
from
ed5483d to
f811599
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Remove old workaround for non-git environments (cherry picked from commit da6a681)
deivid-rodriguez
added
rubygems: skip changelog
and removed
bundler: skip changelog
labels
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Remove old workaround for non-git environments (cherry picked from commit da6a681)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Remove old workaround for non-git environments (cherry picked from commit da6a681)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I noticed that running
ruby setup.rbwas rewriting thebundler.gemspecwhen I run it on Windows on a shared folder and noticed that all line feeds had been rewritten.This is no longer necessary since we no longer use
gitin bundler's gemspec.Tasks:
I will abide by the code of conduct.