Skip to content

Remove MacOS specific gem layout#4833

Merged
bronzdoc merged 3 commits intomasterfrom
remove_macos_specific_layout
Aug 10, 2021
Merged

Remove MacOS specific gem layout#4833
bronzdoc merged 3 commits intomasterfrom
remove_macos_specific_layout

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

What was the end-user or developer problem that led to this PR?

MacOS should properly configure Ruby. They should not expect us to maintain a different layout just for them.

What is your fix for the problem, implemented in this PR?

Don't maintain a specific default layout just for MacOS.

Closes #2890.

Make sure the following tasks are checked

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Ironically, they monkeypatch the code we maintain just for them 🤣 https://opensource.apple.com/source/ruby/ruby-145.40.1/patches/lib_rubygems_defaults.rb.diff.auto.html

MacOS should properly configure Ruby. They should not expect us to
maintain a different layout just for them.
They should properly configure `GEM_PATH` instead.
@deivid-rodriguez deivid-rodriguez force-pushed the remove_macos_specific_layout branch from 77c3e0f to 81dc685 Compare August 9, 2021 11:59
@bronzdoc bronzdoc merged commit ec7ad16 into master Aug 10, 2021
@bronzdoc bronzdoc deleted the remove_macos_specific_layout branch August 10, 2021 02:35
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

This will break gem update --system on ruby packaged by MacOS. Not really supported anyways, but there's no hurry to ship this, we can keep it in master and release it with the next major.

@voxik
Copy link
Copy Markdown
Contributor

voxik commented Nov 30, 2021

Nice, they should use operating_system.rb as every other platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default gems location as framework on macOS

5 participants