Fix a test for bin/bundle update --bundler to pass on ruby/ruby.#5410
Merged
simi merged 1 commit intoruby:masterfrom Mar 22, 2022
Merged
Conversation
deivid-rodriguez
suggested changes
Mar 21, 2022
56416e9 to
9c66ae2
Compare
Member
Author
|
Rebased with the implementation to compare the Bundler version. The |
bin/bundle update --bundler to pass on ruby/rubybin/bundle update --bundler to pass on ruby/ruby.
Consider the case that the latest Bundler version on RubyGems is higher than the `system_bundler_version` (= `Bundler::VERSION`) in `make test-bundler` on ruby/ruby. See <https://bugs.ruby-lang.org/issues/18643>.
9c66ae2 to
bfa2f72
Compare
deivid-rodriguez
approved these changes
Mar 22, 2022
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 23, 2022
…undler-test Fix a test for `bin/bundle update --bundler` to pass on ruby/ruby. (cherry picked from commit 1ff9aac)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change to relax the test is to pass
make test-bundleron ruby/ruby,where the
system_bundler_version(=Bundler::VERSION) is not the latest version on the RubyGems.See https://bugs.ruby-lang.org/issues/18643.
What was the end-user or developer problem that led to this PR?
The test can fail in
make test-bundler(make test-bundler BUNDLER_SPECS="commands/binstubs_spec.rb") in ruby/ruby, where theBundler::VERSIONis not the latest version in RubyGems.What is your fix for the problem, implemented in this PR?
I relaxed the matching criteria not depending on the version number.
I tried to use a regular expression seeing the RSpec
includemethod document,https://relishapp.com/rspec/rspec-expectations/v/3-10/docs/built-in-matchers/include-matcher
However I see there is a syntax error
no implicit conversion of Regexp into String. So, I am just using a string matching.Make sure the following tasks are checked