Ask user to otp at webauthn verification url#6179
Merged
simi merged 3 commits intoruby:webauthn-clifrom Jan 25, 2023
Merged
Conversation
Contributor
jchestershopify
left a comment
There was a problem hiding this comment.
Some small questions. No blockers though.
Contributor
Author
|
cc @simi for review |
jenshenny
approved these changes
Jan 3, 2023
Contributor
jenshenny
left a comment
There was a problem hiding this comment.
Looks good to me, just have a suggestion on the OTP prompt phrasing here: #6179 (comment)
| request.add_field "Authorization", api_key | ||
| end | ||
| end | ||
| response.is_a?(Net::HTTPSuccess) ? response.body : nil |
Contributor
There was a problem hiding this comment.
For hosts that do not have webauthn / "api/v1/webauthn_verification" implemented yet, I'm guessing that there's not going to be a change in behaviour since this method would return nil.
Contributor
|
@simi any thoughts so far? |
simi
reviewed
Jan 12, 2023
6 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is being merged into a feature branch, not main, so that work may continue to be developed in small pieces as we built out webauthn for the CLI
What was the end-user or developer problem that led to this PR?
Users with MFA enabled would like to use security devices (yubikey, touch id, etc) for logging in with WebAuthn on the CLI
What is your fix for the problem, implemented in this PR?
.org feature branch: rubygems/rubygems.org#3298
Matching .org work: rubygems/rubygems.org#3305
Make sure the following tasks are checked