Conversation
Fix fragile tests (cherry picked from commit b261932)
Support Ruby 4.1 (cherry picked from commit 569c5c7)
Remove date require from rebuild command (cherry picked from commit cc460f5)
Retain current bundler version on `bundle clean` (cherry picked from commit 56f1dd7)
Test with Ruby 4.0 and update the latest stable versions of 3.x (cherry picked from commit 904d734)
Fix dependency source bug in bundler (cherry picked from commit 769c025)
Validate more options for add sub-command (cherry picked from commit e7cb043)
Add a missing "require 'etc'" statement: (cherry picked from commit 07c459c)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares RubyGems 4.0.4 and Bundler 4.0.4 for release. The changes include version bumps, bug fixes, and preparation for future Ruby versions.
Changes:
- Version bumps from 4.0.3 to 4.0.4 for both RubyGems and Bundler
- Bug fixes for missing require statement, dependency source handling, and bundle clean behavior
- Added validation for bundler add command options
- Support for Ruby 4.1 in platform detection
- Updated CI workflows with new Ruby versions and GitHub Actions
Reviewed changes
Copilot reviewed 24 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/rubygems.rb | Updates RubyGems version to 4.0.4 |
| bundler/lib/bundler/version.rb | Updates Bundler version to 4.0.4 |
| lib/rubygems/installer.rb | Adds missing require 'etc' with LoadError fallback |
| lib/rubygems/commands/rebuild_command.rb | Removes unused require 'date' |
| bundler/lib/bundler/cli/add.rb | Adds validation for conflicting git/github and branch/ref options |
| bundler/lib/bundler/definition.rb | Fixes dependency source resolution for component gems when switching sources |
| bundler/lib/bundler/runtime.rb | Preserves current bundler version during bundle clean |
| bundler/lib/bundler/rubygems_integration.rb | Fixes version comparison in find_bundler by converting to string |
| bundler/lib/bundler/current_ruby.rb | Extends support from Ruby 4.0 to Ruby 4.0-4.1 |
| test/rubygems/test_gem_commands_*.rb | Fixes test assertions for nmake by adding space before -j flag |
| bundler/spec/install/gemfile/sources_spec.rb | Adds tests for switching gem sources from rubygems to git/path |
| bundler/spec/commands/clean_spec.rb | Adds test for preserving current bundler version |
| bundler/spec/commands/add_spec.rb | Adds tests for new option validation |
| bundler/spec/bundler/current_ruby_spec.rb | Adds Ruby 4.1 platform support |
| CHANGELOG.md | Documents changes for 4.0.4 release |
| bundler/CHANGELOG.md | Documents Bundler changes for 4.0.4 release |
| tool/bundler/*.lock | Updates bundled with version to 4.0.4 |
| bundler/spec/realworld/fixtures/*/Gemfile.lock | Updates bundled with version to 4.0.4 |
| .github/workflows/*.yml | Updates ruby-setup-ruby action and Ruby versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Bug fixes: | ||
|
|
||
| * Add a missing "require 'etc'" statement:. Pull request |
There was a problem hiding this comment.
There is an extra colon after "statement" that should be removed. The sentence should end with "statement." instead of "statement:."
Suggested change
| * Add a missing "require 'etc'" statement:. Pull request | |
| * Add a missing "require 'etc'" statement. Pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's release day!