Removed vendored resolv #9297
Closed
Removed vendored resolv #9297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
remove-vendoered-resolv
branch
from
66d6500 to
35169f1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the vendored resolv library (version 0.6.2) from RubyGems and switches to relying on the bundled resolv-0.7.0 as a default gem. This addresses issue #9277 where MSWindows builds were broken due to a circular dependency: the vendored resolv library required win32-registry, which depends on fiddle, creating an unresolvable bootstrap problem.
Changes:
- Removed vendored resolv-0.6.2 dependency from gem vendor configuration
- Deleted vendored resolv library code and license files
- Updated net-http to use standard resolv library instead of vendored version
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tool/bundler/vendor_gems.rb | Removed resolv gem entry from vendoring configuration |
| tool/bundler/vendor_gems.rb.lock | Removed resolv gem from lockfile (gem list, dependencies, checksums) |
| tool/automatiek/vendor.rb | Removed VendoredGem configuration for resolv including dependencies and patch references |
| lib/rubygems/vendor/resolv/lib/resolv.rb | Deleted entire vendored resolv library implementation (3,483 lines) |
| lib/rubygems/vendor/resolv/COPYING | Deleted vendored resolv license file |
| lib/rubygems/vendor/net-http/lib/net/http.rb | Changed from vendored resolv (require_relative, Gem::Resolv) to standard library (require 'resolv', Resolv) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsbt
force-pushed
the
remove-vendoered-resolv
branch
from
35169f1 to
a6fc613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
From #9277
We should use resolv-0.7.0 that is working without fiddle dependency. But resolv-0.7.0 has C extension, so we couldn't vendor that at rubygems.
What is your fix for the problem, implemented in this PR?
Removed vendored resolv. We should rely bundled resolv as default gems.
Make sure the following tasks are checked