Skip to content

Skip flaky webauthn test on TruffleRuby#9370

Merged
hsbt merged 1 commit intomasterfrom
skip-flaky-test-truffleruby
Mar 6, 2026
Merged

Skip flaky webauthn test on TruffleRuby#9370
hsbt merged 1 commit intomasterfrom
skip-flaky-test-truffleruby

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Mar 6, 2026

from #9352

Pend test_with_webauthn_enabled_failure on TruffleRuby where it fails
intermittently.
Copilot AI review requested due to automatic review settings March 6, 2026 06:18
@hsbt hsbt enabled auto-merge March 6, 2026 06:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the RubyGems test suite to avoid CI instability by marking a flaky WebAuthn-related push command test as pending when running on TruffleRuby.

Changes:

  • Mark test_with_webauthn_enabled_failure as pending on TruffleRuby to avoid flakiness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

end

def test_with_webauthn_enabled_failure
pend "Flaky on TruffleRuby" if RUBY_ENGINE == "truffleruby"
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description links to #9352 and includes details about replacing Psych with a pure-Ruby YAML parser, but this change only adds a TruffleRuby pending guard for a WebAuthn push command test. Please update the PR description to reference the correct upstream change/issue for this flakiness (or remove the unrelated referenced PR content) so the rationale is traceable.

Copilot uses AI. Check for mistakes.
@hsbt hsbt merged commit c0322d7 into master Mar 6, 2026
95 checks passed
@hsbt hsbt deleted the skip-flaky-test-truffleruby branch March 6, 2026 06:45
hsbt added a commit that referenced this pull request Mar 10, 2026
Skip flaky webauthn test on TruffleRuby

(cherry picked from commit c0322d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants