Skip to content

fix: include owner role in gem owner#9403

Merged
colby-swandale merged 1 commit intoruby:masterfrom
gjtorikian:include-owner-role-in-gem-owner
Mar 17, 2026
Merged

fix: include owner role in gem owner#9403
colby-swandale merged 1 commit intoruby:masterfrom
gjtorikian:include-owner-role-in-gem-owner

Conversation

@gjtorikian
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

The gem owner command lists the owners of a gem but does not display their role. This makes it difficult for gem maintainers to see what level of access each person has.

What is your fix for the problem, implemented in this PR?

Display the owner's role in parentheses next to their identifier when listing gem owners, since that information now comes from the API.

Make sure the following tasks are checked

Closes #9267.

@hsbt
Copy link
Member

hsbt commented Mar 17, 2026

👍

@colby-swandale colby-swandale merged commit 0bcfe4b into ruby:master Mar 17, 2026
92 checks passed
@tekknolagi
Copy link

FYI this broke ruby HEAD CI. See errors on ruby/ruby@3092f4f

@gjtorikian
Copy link
Contributor Author

I guess the quickest fix would be to add a nil? guard to not append the role? The proper fix would be to update the test fixtures.

And why does matzbot merge directly into master instead of opening a PR? I have no context.

@hsbt
Copy link
Member

hsbt commented Mar 17, 2026

This is alaready fixed.

ruby/ruby#16413

@tekknolagi
Copy link

Oh super! Thank you!

hsbt pushed a commit that referenced this pull request Mar 25, 2026
fix: include owner role in `gem owner`
(cherry picked from commit 0bcfe4b)
hsbt pushed a commit that referenced this pull request Mar 25, 2026
fix: include owner role in `gem owner`
(cherry picked from commit 0bcfe4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include owner role in gem owner

4 participants