Fix gemspec filename mismatches in stub helper methods

[Copilot]

What was the end-user or developer problem that led to this PR?

In test_gem_stub_specification.rb, two stub helper methods used gemspec filenames that didn't match the gem name defined in their stub content:

• stub_with_version wrote to stub_e-2.gemspec but declared gem name stub_v
• stub_without_version wrote to stub-2.gemspec but declared gem name stub_v

Additionally, both helpers were originally updated to share the same filename (stub_v-2.gemspec), which could cause accidental overwrites if both helpers are used in the same test.

What is your fix for the problem, implemented in this PR?

Rename the gemspec files in both helpers to match their gem names and use distinct filenames to avoid collisions:

• stub_e-2.gemspec → stub_v-with-version.gemspec in stub_with_version
• stub-2.gemspec → stub_v-without-version.gemspec in stub_without_version

Both filenames are now prefixed with stub_v to match the gem name, while remaining distinct to prevent accidental overwrites when both helpers are used in the same test or future refactors.

Note: stub_with_extension (stub_e-2.gemspec for gem stub_e) and stub_without_extension (stub-2.gemspec for gem stub) are correct and unchanged.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

Original prompt

Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"The filename 'stub_e-2.gemspec' in stub_with_version method doesn't match the gem name 'stub_v' defined in the stub content. This inconsistency could lead to confusion or potential file system issues. Consider renaming the file to 'stub_v-2.gemspec' to match the gem name.","fixFiles":[{"filePath":"test/rubygems/test_gem_stub_specification.rb","diff":"diff --git a/test/rubygems/test_gem_stub_specification.rb b/test/rubygems/test_gem_stub_specification.rb\n--- a/test/rubygems/test_gem_stub_specification.rb\n+++ b/test/rubygems/test_gem_stub_specification.rb\n@@ -221,7 +221,7 @@\n   end\n \n   def stub_with_version\n-    spec = File.join @gemhome, \"specifications\", \"stub_e-2.gemspec\"\n+    spec = File.join @gemhome, \"specifications\", \"stub_v-2.gemspec\"\n     File.open spec, \"w\" do |io|\n       io.write <<~STUB\n         # -*- encoding: utf-8 -*-\n"}]},{"message":"The filename 'stub-2.gemspec' in stub_without_version method doesn't match the gem name 'stub_v' defined in the stub content. This inconsistency could cause file lookup issues. The filename should be 'stub_v-2.gemspec' to match the gem name in the stubline.","fixFiles":[{"filePath":"test/rubygems/test_gem_stub_specification.rb","diff":"diff --git a/test/rubygems/test_gem_stub_specification.rb b/test/rubygems/test_gem_stub_specification.rb\n--- a/test/rubygems/test_gem_stub_specification.rb\n+++ b/test/rubygems/test_gem_stub_specification.rb\n@@ -244,7 +244,7 @@\n   end\n \n   def stub_without_version\n-    spec = File.join @gemhome, \"specifications\", \"stub-2.gemspec\"\n+    spec = File.join @gemhome, \"specifications\", \"stub_v-2.gemspec\"\n     File.open spec, \"w\" do |io|\n       io.write <<~STUB\n         # -*- encoding: utf-8 -*-\n"}]}]

[Copilot]

Pull request overview

This PR updates Rubygems stub-spec test helpers so the gemspec filenames match the gem name declared inside the stub content, reducing confusion and avoiding potential lookup mismatches during debugging.

Changes:

• Renamed the gemspec path written by stub_with_version to use stub_v-2.gemspec.
• Renamed the gemspec path written by stub_without_version to use stub_v-2.gemspec.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

stub_with_version now writes to stub_v-2.gemspec, but stub_without_version writes to the exact same path. Because these helpers generate different gemspec contents, calling both in the same test (or reusing helpers in new tests) would overwrite the earlier stub and make failures confusing. Use distinct filenames per helper (while still matching the gem name), e.g. keep stub_v-2.gemspec here and give the no-version helper a different name like stub_v-noversion.gemspec (or similar).

Suggested change

	spec = File.join @gemhome, "specifications", "stub_v-2.gemspec"
	spec = File.join @gemhome, "specifications", "stub_v-with-version.gemspec"

[Copilot]

This helper writes to stub_v-2.gemspec, which is also used by stub_with_version. Since the two helpers create different gemspec stubs, sharing a filename can cause accidental overwrites if both helpers are used in the same test or future refactors. Consider using a distinct filename for the no-version case (still prefixed with stub_v to match the gem name).

Suggested change

	spec = File.join @gemhome, "specifications", "stub_v-2.gemspec"
	spec = File.join @gemhome, "specifications", "stub_v-without-version.gemspec"

[hsbt]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied in e06bef0 — stub_with_version now uses stub_v-with-version.gemspec and stub_without_version uses stub_v-without-version.gemspec, giving each helper a distinct filename while still matching the gem name.