Gracefully handle missing checksums in Compact Index#9492
Open
jneen wants to merge 1 commit intoruby:masterfrom
Open
Gracefully handle missing checksums in Compact Index#9492jneen wants to merge 1 commit intoruby:masterfrom
jneen wants to merge 1 commit intoruby:masterfrom
Conversation
jneen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Fixes #9491.
What is your fix for the problem, implemented in this PR?
I've changed
CompactIndexClient::Parser#parse_version_checksumto fail gracefully in the way it looks like @martinemde originally intended, by placing the nil check before any addition.Make sure the following tasks are checked