Replace #9506 with a targeted :ruby_repo skip#9509
Merged
Conversation
The blanket skip in checksums_section from #9506 caused 82 ruby-core test failures whose lockfile expectations legitimately include the bundler checksum (paths that go through `bundle install` where bundler is activated as a gem). Revert that change and instead tag only the affected setup_spec example with :ruby_repo, since its `ruby "require 'bundler/setup'"` invocation is the one case where bundler is loaded from $LOAD_PATH and Source::Metadata's synthetic bundler spec has no cache_file on disk. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Bundler’s spec helpers/tests so ruby-core runs don’t broadly skip bundler checksum expectations, and instead only skip the single example that hits the “bundler loaded from $LOAD_PATH as a default gem” edge case.
Changes:
- Remove the
Spec::Path.ruby_core?condition fromchecksums_sectionso bundler checksums are included consistently again. - Tag the specific
setup_specexample that fails on ruby-core with:ruby_repoand document why it’s excluded there.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spec/support/checksums.rb |
Reverts the blanket ruby-core skip so checksum expectations match lockfile generation in more ruby-core scenarios. |
spec/runtime/setup_spec.rb |
Applies a targeted :ruby_repo exclusion to the single failing example and adds rationale inline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is your fix for the problem, implemented in this PR?
The blanket skip in checksums_section from #9506 caused ruby-core test failures whose lockfile expectations legitimately include the bundler checksum (paths that go through
bundle installwhere bundler is activated as a gem).Revert that change and instead tag only the affected setup_spec example with :ruby_repo, since its
ruby "require 'bundler/setup'"invocation is the one case where bundler is loaded from $LOAD_PATH and Source::Metadata's synthetic bundler spec has no cache_file on disk.Make sure the following tasks are checked