Skip to content

JRuby 9.3 (head) and forward ships bundler#164

Merged
eregon merged 2 commits intoruby:masterfrom
enebo:jruby_bundler_head
Mar 25, 2021
Merged

JRuby 9.3 (head) and forward ships bundler#164
eregon merged 2 commits intoruby:masterfrom
enebo:jruby_bundler_head

Conversation

@enebo
Copy link
Copy Markdown
Contributor

@enebo enebo commented Mar 24, 2021

JRuby 9.3 will ship with bundler and jruby-head already does. This PR, like truffleruby, will not bother installing bundler since it is already installed.

I was confused about one thing. When JRuby 9.3 is released how do we change this action to say bundler is already installed? ruby-version appears to only report 'jruby' and 'jruby-head' to this JS function. I would like to make sure when we do put out that version we are not again reinstalling bundler.

Copy link
Copy Markdown
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.
When there is a 9.3 release we should update that logic to use something like the === 'ruby' logic for 9.3.

@eregon eregon merged commit 4f47b36 into ruby:master Mar 25, 2021
@eregon
Copy link
Copy Markdown
Member

eregon commented Mar 25, 2021

I added 9.3 to return true there too: 5ee1019

However this function alone doesn't decide whether to install Bundler or not.
It's a bit more complicated than that, I forgot: dddacd7
So for releases, we still install the latest Bundler release, which I think helps to get the latest Bundler fixes.

@enebo
Copy link
Copy Markdown
Contributor Author

enebo commented Mar 25, 2021

@eregon Thanks amazingly I had that in my original PR but I could not figure out how rubyVersion would get the 9.3. tbh part of me does not want to know :) Thanks for the additional tweak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants