JRuby 9.3 (head) and forward ships bundler#164
Merged
eregon merged 2 commits intoruby:masterfrom Mar 25, 2021
Merged
Conversation
eregon
approved these changes
Mar 25, 2021
Member
eregon
left a comment
There was a problem hiding this comment.
Looks good, thanks.
When there is a 9.3 release we should update that logic to use something like the === 'ruby' logic for 9.3.
Member
Contributor
Author
|
@eregon Thanks amazingly I had that in my original PR but I could not figure out how rubyVersion would get the 9.3. tbh part of me does not want to know :) Thanks for the additional tweak! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JRuby 9.3 will ship with bundler and jruby-head already does. This PR, like truffleruby, will not bother installing bundler since it is already installed.
I was confused about one thing. When JRuby 9.3 is released how do we change this action to say bundler is already installed? ruby-version appears to only report 'jruby' and 'jruby-head' to this JS function. I would like to make sure when we do put out that version we are not again reinstalling bundler.