Fix bundler: with a minor version installing the wrong version
#306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also has the dist.js updated. I wasn't sure what your PR pattern is in this repo, so if this is wrong, let me know and I can remove that. |
Fryguy
force-pushed
the
fix_version_constraint
branch
from
3a1a3d3 to
d5ff41a
Compare
eregon
approved these changes
Apr 5, 2022
|
The CI seems to fail, see https://github.com/ruby/setup-ruby/runs/5836332794?check_suite_focus=true |
eregon
reviewed
Apr 5, 2022
eregon
reviewed
Apr 5, 2022
If passed `bundler: 2.2`, setup-ruby would install bundler 2.3, because it would generate a constraint that looks like `~> 2.2`. This unexpectedly installs the latest of the 2.x series, but the expectation is that it would install the latest of the 2.2.x series. Fixes ruby#304
Fryguy
force-pushed
the
fix_version_constraint
branch
from
bf74619 to
46adeca
Compare
|
Ok, updated with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passed
bundler: 2.2, setup-ruby would install bundler 2.3, becauseit would generate a constraint that looks like
~> 2.2. Thisunexpectedly installs the latest of the 2.x series, but the expectation
is that it would install the latest of the 2.2.x series.
Fixes #304