-
-
Notifications
You must be signed in to change notification settings - Fork 345
Add support for gems.rb/gems.locked during bundle install.
#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you missed this case:
Line 178 in a2ee959
| const gemfilePath = `${process.env['BUNDLE_GEMFILE'] || 'Gemfile'}.lock` |
|
Thanks for the PR. |
|
Is there any reason to use I'm not looking forward to support every possible experimental Bundler feature, due to the cost to maintain that. |
| if (!fs.existsSync('Gemfile')) { | ||
| console.log('No Gemfile, skipping "bundle install" and caching') | ||
| return | ||
| if (await bundleInstallSpecific('gems.rb', 'gems.locked', platform, engine, version)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundleInstallSpecific does not return in the successful case.
Does the if work here? It doesn't seem so:
> async function foo() { console.log("foo"); }
> async function call() { var r=await foo(); console.log(r); if (r) { console.log("OK") } else { console.log("NOPE") } }
undefined
> call()
foo
Promise { <pending> }
> undefined
NOPE
|
I'll revert this, let's review & discuss it properly before merging. |
|
I’m already using it so please don’t revert it. Why don’t we just fix the issues you have. I tested both cases in my own repos and it seemed to work fine. |
How, since it's not released? |
|
I am using master. https://github.com/ioquatix/bake/runs/1064255388?check_suite_focus=true |
|
I see, sorry about that. |
|
Sure, I completely understand your POV, but I think it warranted just a tiny bit more discussion, given how easy it is to make the changes you requested. |
|
Can you please review #84 |
Fixes part of #52 - doesn't work with
gems.rb.