Fix compatibility to ruby-3.2 #861
Merged
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which is the default ruby version on Github Actions.
eregon
reviewed
Jan 18, 2026
| def validate(versions, allowed_urls_regexps) | ||
| versions.values.flat_map(&:values).each do |url| | ||
| if allowed_urls_regexps.none? { |regexp| regexp.match? url } | ||
| if allowed_urls_regexps.none? { |regexp| regexp.match? url.to_s } |
Member
There was a problem hiding this comment.
Probably we should convert the URI to a String earlier, we don't want to have URI objects in the JSON.
It works currently but might as well have consistent types for this method.
I'll fix it.
Member
The check in this repo CI uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which is the default ruby version on Github Actions.
URI::Generic#to_strwas added in ruby-3.3.That made the windows new version check fails since 2026-01-13.
Also add the new RubyInstaller releases 4.0.1-1 and 3.2.10-1 to make the PR succeed.