Skip to content

Refactor matrix script#897

Merged
ntkme merged 1 commit intomasterfrom
refactor-matrix
Mar 27, 2026
Merged

Refactor matrix script#897
ntkme merged 1 commit intomasterfrom
refactor-matrix

Conversation

@ntkme
Copy link
Copy Markdown
Collaborator

@ntkme ntkme commented Mar 27, 2026

@eregon Please take a look if this looks good to you.

Copy link
Copy Markdown
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I totally missed that variable 😅

@eregon
Copy link
Copy Markdown
Member

eregon commented Mar 27, 2026

BTW do you have an idea how to apply this to all truffleruby/truffleruby+graalvm versions >= 34 (so head, 34, 40, etc), although 34, 40 are not out yet, but it'd be nice if CI doesn't break when they are.

@ntkme ntkme merged commit ba696ad into master Mar 27, 2026
426 checks passed
@ntkme ntkme deleted the refactor-matrix branch March 27, 2026 23:08
@eregon
Copy link
Copy Markdown
Member

eregon commented Mar 27, 2026

Ah given truffleruby_versions = %w[truffleruby truffleruby-head truffleruby+graalvm truffleruby+graalvm-head] it's actually trivial, we just need to wait for 34 to be out then, and it'll be fixed for versions after that.

(sorry, it's late here)

@ntkme
Copy link
Copy Markdown
Collaborator Author

ntkme commented Mar 27, 2026

In theory, it can be done by checking the latest version available in ruby-builder-versions.json, and generating the matrix differently. However, I think trying to handle a future change before it comes out seems to be a bit over-engineered for a simple one-time issue.


As 34 come out, as part of the ruby-builder-bot PR, we can just manually add a commit to have it changed from:

truffleruby_versions = %w[truffleruby truffleruby-head truffleruby+graalvm truffleruby+graalvm-head]
matrix += non_windows_runners.product(truffleruby_versions)

To:

truffleruby_versions = %w[truffleruby truffleruby-head truffleruby+graalvm truffleruby+graalvm-head]
matrix += (macos_arm64_runners + ubuntu_runners).product(truffleruby_versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants