Allow customising project ID in cache key rather than it always including working directory#905
Open
ZimbiX wants to merge 1 commit intoruby:masterfrom
Open
Allow customising project ID in cache key rather than it always including working directory#905ZimbiX wants to merge 1 commit intoruby:masterfrom
ZimbiX wants to merge 1 commit intoruby:masterfrom
Conversation
…ding working directory To fix cache key consistency for builds with an ephemeral working directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #904
I decided to go with something simple rather than using the Git repo remote URL which I'd first thought to use. The URL might not suit all use-cases - perhaps someone has multiple bundles in the one repo (hence you having added the workdir to distinguish). Instead, a simple customisable string value
project-idwould allow using the action multiple times in a job for different directories with a differentproject-id.Testing
Tested and working in our GitHub Actions workflow using:
Logs: