Skip to content

Conversation

@herwinw
Copy link
Member

@herwinw herwinw commented May 28, 2025

Some tests check for syntax errors, we should run those with both official supported parsers.

I kept this on Ruby 3.4.2 instead of the latest 3.4.4 for consistency, we should probably update all CI jobs to the latest minor releases, but I kept that out of scope for this case.

Some tests check for syntax errors, we should run those with both
official supported parsers.
@eregon
Copy link
Member

eregon commented May 28, 2025

Is --parser=parse.y officially supported?

Anyway I think it's fine to add for now.
If there are differences I think we should spec Prism's behavior, since that's what's used by most Ruby implementations by now.

@eregon
Copy link
Member

eregon commented May 28, 2025

I kept this on Ruby 3.4.2 instead of the latest 3.4.4 for consistency, we should probably update all CI jobs to the latest minor releases, but I kept that out of scope for this case.

Could you make a PR for that?
I'll look into fixing the CI.

@eregon eregon merged commit 69fd171 into ruby:master May 28, 2025
9 of 12 checks passed
@herwinw herwinw deleted the ci_parse_y branch May 29, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants