Add specs for defined? on protected methods#1362
Merged
eregon merged 1 commit intoMay 27, 2026
Merged
Conversation
Covers protected methods accessed via subclass receiver, base-class receiver, and a shared included module. The module case is guarded by ruby_bug "#22076" until 4.1. MRI's defined? returned nil when the call would have succeeded; fix is in master with backports REQUIRED for 3.3, 3.4, 4.0.
sampokuokkanen
force-pushed
the
defined-protected-method-coverage
branch
from
075e387 to
e21a444
Compare
eregon
approved these changes
May 27, 2026
Member
eregon
left a comment
eregon
left a comment
There was a problem hiding this comment.
Looks good, thank you and sorry for slow review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers protected methods accessed via subclass receiver, base-class receiver, and a shared included module. The module case is guarded by ruby_bug "#22076" until 4.1. MRI's defined? returned nil when the call would have succeeded. Fix is in master with backports marked as required for 3.3, 3.4, 4.0.
MRI fix: ruby/ruby#17069
Bug #22076
Hopefully I used
ruby_bugcorrectly.