Add hint when if or unless is followed by do
#244
+185
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo in RSpec is typing `if` instead of `it`. Depending on the font, they can be hard to distinguish at a glance: ```ruby if "does something" do # Should be `it "does something" do` # ... end ``` This results in a confusing "Unmatched keyword, missing `end'?" error because both `if` and `do` require their own `end`. And some keywords like `while` and `loop` take `do`, so it's not always obvious that `if` or `unless` don't. The message needs to accommodate a scenario where it's unknown if the value inside accepts a block like: ```ruby if method_call do end ``` This might be perfectly valid ruby code, so you wouldn't want to assert "if does not take a do" (since that's not the problem...the problem is that both if and do require an `end` to close, but the code doesn't provide that). Before: ``` Unmatched keyword, missing `end' ? 2 describe "something" do > 3 if "does something" do > 5 end 6 end ``` After: ``` Unmatched keyword, missing `end' ? Both `if` and `do` require an `end`. 2 describe "something" do > 3 if "does something" do > 5 end 6 end ``` Close #206
schneems
force-pushed
the
schneems/if-do
branch
from
f6d601a to
9eba2fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo in RSpec is typing
ifinstead ofit. Depending on the font, they can be hard to distinguish at a glance:This results in a confusing "Unmatched keyword, missing
end'?" error because bothifanddorequire their ownend. And some keywords likewhileandlooptakedo, so it's not always obvious thatiforunless` don't.The message needs to accommodate a scenario where it's unknown if the value inside accepts a block like:
This might be perfectly valid ruby code, so you wouldn't want to assert "if does not take a do" (since that's not the problem...the problem is that both if and do require an
endto close, but the code doesn't provide that.Before:
After:
Close #206