Set a default EnvUtil.timeout_scale for TruffleRuby to help avoid transient failures#23
Merged
eregon merged 1 commit intoruby:masterfrom Apr 16, 2026
Conversation
Member
Author
|
Given Line 8 in f31f6db ruby/ruby#16754 |
nevans
reviewed
Apr 16, 2026
| # Setting a default timeout scale helps avoid transient failures for tests relying on timeouts. | ||
| # We choose 10 because it is the same number used in CRuby CI on macOS: | ||
| # https://github.com/ruby/ruby/blob/9d46b0c735877f152a0b4b16b8153c6f395dee28/.github/workflows/macos.yml#L133 | ||
| self.timeout_scale = 10 |
There was a problem hiding this comment.
Suggested change
| self.timeout_scale = 10 | |
| @timeout_scale = 10 |
Alternatively, call self.timeout_scale = 10 in the regular class body (outside the singleton class body). :)
|
@eregon FYI, this is breaking net-imap's truffleruby builds. |
Member
Author
|
@nevans Sorry about that, will make a fix ASAP. |
eregon
added a commit
to eregon/test-unit-ruby-core
that referenced
this pull request
Apr 17, 2026
eregon
added a commit
that referenced
this pull request
Apr 17, 2026
Member
Author
|
Fix in #24 and I tested locally it fixes it for net-imap with |
eregon
added a commit
to eregon/ruby
that referenced
this pull request
Apr 17, 2026
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.