Fix NotImplementedError in SigTyProcNode for RBS proc types#335
Merged
mame merged 1 commit intoruby:masterfrom Aug 12, 2025
Merged
Conversation
Previously, using proc types in RBS files (e.g., ^() -> Integer) would raise NotImplementedError when TypeProf tried to process them through SigTyProcNode#covariant_vertex0. This commit: - Adds initialize method to SigTyProcNode to properly parse RBS::Types::Proc - Implements covariant_vertex0 and contravariant_vertex0 methods - Wraps RBS::Types::Function in RBS::MethodType for compatibility - Adds comprehensive test scenarios for proc type handling The implementation currently returns the base Proc type without detailed function signature information, which can be enhanced in the future. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
mame
approved these changes
Aug 12, 2025
Member
|
This change looks need more work, but is definitely better than NotImplementedError. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, using proc types in RBS files (e.g., ^() -> Integer) would raise NotImplementedError when TypeProf tried to process them through SigTyProcNode#covariant_vertex0.
This commit:
The implementation currently returns the base Proc type without detailed function signature information, which can be enhanced in the future.
🤖 Generated with Claude Code