Skip to content

Update regex to get the version #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mame merged 1 commit into from
May 1, 2025
Merged

Update regex to get the version #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import * as vscode from 'vscode';
import { LanguageClient, LanguageClientOptions, ServerOptions, TextDocumentFilter } from 'vscode-languageclient/node';
import * as net from 'net';
import * as child_process from 'child_process';

Check warning on line 6 in src/extension.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 3.3.6) 

Import name `child_process` must match one of the following formats: camelCase, PascalCase

Check warning on line 6 in src/extension.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 3.3.6) 

Import name `child_process` must match one of the following formats: camelCase, PascalCase
import { existsSync } from 'fs';

interface Invoking {
Expand Down Expand Up @@ -152,7 +152,7 @@
if (code === 0) {
const str = output.trim();
log(`typeprof version: ${str}`);
const version = /^typeprof (\d+.\d+.\d+)$/.exec(str);
const version = /typeprof (\d+.\d+.\d+)$/m.exec(str);
Copy link
Copy Markdown
Contributor Author

@sinsoku sinsoku May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I included this /m flag by mistake.
It is unnecessary and will be removed.

if (version && version.length === 2) {
if (compareVersions(version[1], '0.20.0') >= 0) {
callback(null, version[1]);
Expand Down