Skip to content

Translate documentation/from-other-languages (vi)#262

Merged
1 commit merged intoruby:vi-translationfrom
thanhbc:translate-doc
Aug 19, 2013
Merged

Translate documentation/from-other-languages (vi)#262
1 commit merged intoruby:vi-translationfrom
thanhbc:translate-doc

Conversation

@thanhbc
Copy link
Copy Markdown
Contributor

@thanhbc thanhbc commented Aug 7, 2013

No description provided.

@thanhbc
Copy link
Copy Markdown
Contributor Author

thanhbc commented Aug 7, 2013

@JONESLEE85 @stomar pls proof-read . tks

@thanhbc
Copy link
Copy Markdown
Contributor Author

thanhbc commented Aug 8, 2013

@JONESLEE85 fixed pls review again

@runlevel5
Copy link
Copy Markdown
Member

@thanhbc can you please change the commit message to Translate documentation/ruby-from-other-languages (vi)?

@thanhbc
Copy link
Copy Markdown
Contributor Author

thanhbc commented Aug 9, 2013

fixed as you said @JONESLEE85

@runlevel5
Copy link
Copy Markdown
Member

@stomar please review again and merge. It's a okay from me.

@runlevel5
Copy link
Copy Markdown
Member

@stomar any chance you could help review this week? cheers

@stomar
Copy link
Copy Markdown
Contributor

stomar commented Aug 14, 2013

Sorry, won't be online before middle of next week.

@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2013

@stomar do you mind if I review? I'll spend this week finishing what I have pending. (cc @JONESLEE85)

@runlevel5
Copy link
Copy Markdown
Member

@stomar I don't mind @hagarelvikingo help out

@ghost
Copy link
Copy Markdown

ghost commented Aug 15, 2013

@JONESLEE85 👍 I'm on it.

@runlevel5
Copy link
Copy Markdown
Member

@hagarelvikingo any news?

@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2013

@JONESLEE85 yes. The document looks good, the format looks good and the code works (tested it). However, I had problems with running bundle exec rake preview on my machine, that's why I didn't answer properly in the first place. But it's ok to me.

@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2013

@thanhbc @JONESLEE85 it's ok 👍 Should I merge?

@runlevel5
Copy link
Copy Markdown
Member

@hagarelvikingo please merge

ghost pushed a commit that referenced this pull request Aug 19, 2013
Translate documentation/from-other-languages (vi)
@ghost ghost merged commit faec5be into ruby:vi-translation Aug 19, 2013
@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2013

Done 👍

@stomar
Copy link
Copy Markdown
Contributor

stomar commented Aug 21, 2013

@JONESLEE85 Why the rush?

The latest change (renaming of to-ruby-from-c-and-c-) had not been incorporated, I fixed it (see commit 0c55382).

Also, in the future please avoid trailing whitespace and missing newlines at end-of-file.

hsbt pushed a commit that referenced this pull request Dec 20, 2025
Why Ruby Ecosystem セクションに Matz のコメントを追加
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants