Skip to content

Added a release date format check to the linter #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a release date format check to the linter #3668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions _data/releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@
# 3.3 series

- version: 3.3.10
date: '2025-10-23'
date: 2025-10-23
post: "/en/news/2025/10/23/ruby-3-3-10-released/"
url:
gz: https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.10.tar.gz
Expand All @@ -363,7 +363,7 @@
zip: 70ee931fe6ceca0f105e270c882fc019299450fbe75b3da4cadc14a544270eda876eb8cba47a164cac2ada3116b70e6c24efa7061ceab62c1d4af20a16caaf35

- version: 3.3.9
date: '2025-07-24'
date: 2025-07-24
post: "/en/news/2025/07/24/ruby-3-3-9-released/"
url:
gz: https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.9.tar.gz
Expand Down Expand Up @@ -727,7 +727,7 @@
# 3.2 series

- version: 3.2.9
date: '2025-07-24'
date: 2025-07-24
post: "/en/news/2025/07/24/ruby-3-2-9-released/"
url:
gz: https://cache.ruby-lang.org/pub/ruby/3.2/ruby-3.2.9.tar.gz
Expand Down
1 change: 1 addition & 0 deletions lib/linter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def check_releases
errors[release] << invalid_url_message(release.post) if release.post_url_invalid?
errors[release] << "release date and post date do not match" if release.date_mismatch?
errors[release] << missing_post_message(release.post_filename) if release.post_missing?
errors[release] << "release date is a string, not a Date object" if release.date.is_a?(String)
end
end

Expand Down
11 changes: 11 additions & 0 deletions test/test_linter_invalid_release_data.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,15 @@
create_file("_data/releases.yml", content)
_(linter_output).must_match "release date and post date do not match"
end

it "reports release data with wrong date format" do
content = <<~YAML
- version: 2.7.1
date: '2020-01-01'
post: /en/news/2020/01/01/post/
YAML

create_file("_data/releases.yml", content)
_(linter_output).must_match "release date is a string, not a Date object"
end
end
Loading