Update require statement for libxml_ruby 6.0.0#63
Merged
kou merged 1 commit intoruby:masterfrom Apr 9, 2026
Merged
Conversation
Requiring libxml no longer works, but `libxml-ruby` does work on older versions too.
Member
Author
|
The failures on Ruby 2.5 seem to be unrelated to this change, but an issue with bundler versions ("Your RubyGems version (2.7.6.3) has a bug that prevents |
Member
|
Let's remove Ruby 2.5 from our CI. |
kou
pushed a commit
that referenced
this pull request
Apr 10, 2026
* Remove Ruby 2.5, this one is broken outside of the control of the gem (see #63 (comment)) * Add missing Ruby 4.0 --------- Co-authored-by: Herwin <herwinw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requiring libxml no longer works, but
libxml-rubydoes work on older versions too.Tested it locally with
bundle exec rake test XMLRPC_PARSER=libxmlwith libxml-ruby 6.0.0 and 5.0.6, I'm not sure if the CI includes this.