Skip to content

adds a benchfella benchmark#7

Merged
mindreframer merged 1 commit intomasterfrom
feature/benchmark
May 4, 2016
Merged

adds a benchfella benchmark#7
mindreframer merged 1 commit intomasterfrom
feature/benchmark

Conversation

@mindreframer
Copy link
Copy Markdown
Member

problem:

solution:

  • use benchfella package
  • small script

results:

  • the Macro.underscore version is roughly 2x faster... that time adds up on larger json payloads, so I'll keep it for now. It's always possible to switch it to something custom later, if that becomes a problem.
## BasicBench
macro_underscore - short      100000   11.23 µs/op
regex_underscore - short      100000   26.51 µs/op
macro_underscore - long        50000   45.81 µs/op
regex_underscore - long        20000   75.77 µs/op

problem:
- in PR #5 I wanted to compare different implementations for underscoring


solution: 
- use benchfella package 
- small script

results: 
- the Macro.underscore version is roughly 2x faster... that time adds up on larger json payloads, so I'll keep it for now. It's always possible to switch it to something custom later, if that becomes a problem. 

```
## BasicBench
macro_underscore - short      100000   11.23 µs/op
regex_underscore - short      100000   26.51 µs/op
macro_underscore - long        50000   45.81 µs/op
regex_underscore - long        20000   75.77 µs/op
```
@mindreframer
Copy link
Copy Markdown
Member Author

@anronin finally came to do some benchmarking... the macro.underscore version is approximately 2x faster... will keep it for now. thx for the proposal!

@mindreframer mindreframer merged commit f94ebb0 into master May 4, 2016
@mindreframer mindreframer deleted the feature/benchmark branch May 4, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant