adds a benchfella benchmark#7
Merged
mindreframer merged 1 commit intomasterfrom May 4, 2016
Merged
Conversation
problem: - in PR #5 I wanted to compare different implementations for underscoring solution: - use benchfella package - small script results: - the Macro.underscore version is roughly 2x faster... that time adds up on larger json payloads, so I'll keep it for now. It's always possible to switch it to something custom later, if that becomes a problem. ``` ## BasicBench macro_underscore - short 100000 11.23 µs/op regex_underscore - short 100000 26.51 µs/op macro_underscore - long 50000 45.81 µs/op regex_underscore - long 20000 75.77 µs/op ```
Member
Author
|
@anronin finally came to do some benchmarking... the macro.underscore version is approximately 2x faster... will keep it for now. thx for the proposal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem:
solution:
results: