Skip to content

Revert change to per-pack rubocop usage #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexevanczuk merged 2 commits into from
Nov 15, 2022
Merged

Revert change to per-pack rubocop usage #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ba559
Revert "Fix bug with per-pack rubocop usage (#23)"
Nov 15, 2022
74b1751
Revert change to per-pack rubocop usage
Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
modularization_statistics (2.0.1)
modularization_statistics (2.0.2)
code_ownership
code_teams
dogapi
Expand Down
1 change: 0 additions & 1 deletion lib/modularization_statistics/private/metrics/packages_by_team.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ def self.get_package_metrics_by_team(all_packages, app_name)
team_tags = Metrics.tags_for_team(team_name) + [app_level_tag]
all_metrics << GaugeMetric.for('by_team.all_packages.count', packages_by_team.count, team_tags)
all_metrics += Metrics::PackwerkCheckerUsage.get_checker_metrics('by_team', packages_by_team, team_tags)
all_metrics += Metrics::RubocopUsage.get_metrics('by_team', packages_by_team, team_tags)
all_metrics += Metrics::PublicUsage.get_public_usage_metrics('by_team', packages_by_team, team_tags)
#
# VIOLATIONS (implicit dependencies)
Expand Down
2 changes: 1 addition & 1 deletion modularization_statistics.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Gem::Specification.new do |spec|
spec.name = 'modularization_statistics'
spec.version = '2.0.1'
spec.version = '2.0.2'
spec.authors = ['Gusto Engineers']
spec.email = ['dev@gusto.com']

Expand Down
4 changes: 0 additions & 4 deletions spec/modularization_statistics_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,6 @@ module ModularizationStatistics # rubocop:disable RSpec/DescribedClassModuleWrap
expect(metrics).to include_metric GaugeMetric.for('by_team.using_public_directory.count', 0, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_team.all_files.count', 2, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_team.public_files.count', 0, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_team.rubocops.packs_typedpublicapis.strict.count', 0, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_team.rubocops.packs_typedpublicapis.true.count', 0, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_team.rubocops.packs_rootnamespaceispackname.strict.count', 0, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_team.rubocops.packs_rootnamespaceispackname.exclusions.count', 0, Tags.for(['app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_package.using_public_directory.count', 0, Tags.for(['package:packs/only_package', 'app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_package.all_files.count', 2, Tags.for(['package:packs/only_package', 'app:MyApp', 'team:Unknown']))
expect(metrics).to include_metric GaugeMetric.for('by_package.public_files.count', 0, Tags.for(['package:packs/only_package', 'app:MyApp', 'team:Unknown']))
Expand Down