Skip to content

Is rubocop-packs a true dependency? #105

@technicalpickles

Description

@technicalpickles

I was looking at flamegraphs of our app boot time (as one does), and got curious that rubocop was being loaded. I was able to trace it back to:

  • lib/packs.rb requires rubocop-packs
  • rubocop-packs requires rubocop

I've looked over the code in the repo, and at first glance, it doesn't seem like we're calling anything in that gem, or rubocop for that matter. The closest I can see is Packs::RubocopPostProcessor used in a few places, but even that isn't actually calling rubocop.

I see a few possibilities:

  • it is used directly. cool, keep the dependency, but try to make it lazily loaded if possible
  • it is used indirectly, or maybe something just needs it required at some point. maybe find a better place to load it?
  • it is not used. then it can be removed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions