Skip to content

Do not add dependency to parent pack if subpack is ignored dependency#128

Merged
ashleywillard merged 2 commits intomainfrom
aw/moved-subpack-ignored-dependencies
Nov 16, 2023
Merged

Do not add dependency to parent pack if subpack is ignored dependency#128
ashleywillard merged 2 commits intomainfrom
aw/moved-subpack-ignored-dependencies

Conversation

@ashleywillard
Copy link
Copy Markdown
Contributor

If we have a file like this for packs/fruit:
fruit.yml

dependencies:
  - packs/orange
ignored_dependencies:
  - packs/apple

and we move packs/apple under the parent packs/fruit, we get

dependencies:
  - packs/orange
  - packs/fruit/apple
ignored_dependencies:
  - packs/fruit/apple

This PR changes move_to_parent such that this is now the output:

dependencies:
  - packs/orange
ignored_dependencies:
  - packs/fruit/apple

Comment thread lib/packs/private.rb
end
end

if other_package.name == parent_name &&
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had to be moved after replacing ignored dependencies so we can look for the new package name

@ashleywillard ashleywillard enabled auto-merge (squash) November 16, 2023 17:46
@ashleywillard ashleywillard merged commit 2adede7 into main Nov 16, 2023
@ashleywillard ashleywillard deleted the aw/moved-subpack-ignored-dependencies branch November 16, 2023 19:16
Copy link
Copy Markdown
Contributor

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants