Have bin/packs check use PackwerkWrapper#69
Merged
alexevanczuk merged 1 commit intomainfrom Dec 19, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
bin/packwerk checkwill fail if passed a file that doesn't apply to the include and exclude paths that packwerk looks at.However, the expected behavior is for packwerk to succeed, since there were no failures on the inputted files. This is an issue with pre-commit hooks, which will provide the user feedback there was a packwerk issue when really we were just testing the staged files to be committed. We could push this complexity to the pre-commit hook, but there's not a clear way for how to ask packwerk what files would be included.
For now, we use the packwerk wrapper to address this, as the packwerk wrapper will catch that error message and throw it away.