Skip to content

Bump ParsePackwerk #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexevanczuk merged 2 commits into from
Dec 27, 2022
Merged

Bump ParsePackwerk #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780f763
Bump ParsePackwerk
Dec 27, 2022
b09a93f
bump version
Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
# See https://docs.rubocop.org/rubocop/configuration
AllCops:
NewCops: enable
SuggestExtensions: false
Exclude:
- vendor/bundle/**/**

Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ GIT
PATH
remote: .
specs:
use_packs (0.0.10)
use_packs (0.0.11)
code_ownership
colorize
packwerk
Expand Down Expand Up @@ -78,7 +78,7 @@ GEM
mini_portile2 (~> 2.8.0)
racc (~> 1.4)
parallel (1.22.1)
parse_packwerk (0.17.0)
parse_packwerk (0.18.0)
sorbet-runtime
parser (3.1.2.0)
ast (~> 2.4.1)
Expand Down
3 changes: 2 additions & 1 deletion lib/use_packs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ def self.lint_package_yml_files!(packs)
enforce_privacy: p.enforce_privacy,
enforce_dependencies: p.enforce_dependencies,
dependencies: p.dependencies.uniq.sort,
metadata: p.metadata
metadata: p.metadata,
config: p.config
)
ParsePackwerk.write_package_yml!(new_package)
end
Expand Down
12 changes: 8 additions & 4 deletions lib/use_packs/private.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ def self.move_to_parent!(
enforce_privacy: package.enforce_dependencies,
enforce_dependencies: package.enforce_dependencies,
dependencies: package.dependencies,
metadata: package.metadata
metadata: package.metadata,
config: package.config
)
ParsePackwerk.write_package_yml!(new_package)
ParsePackwerk.bust_cache!
Expand Down Expand Up @@ -200,7 +201,8 @@ def self.move_to_parent!(
enforce_privacy: other_package.enforce_privacy,
enforce_dependencies: other_package.enforce_dependencies,
dependencies: new_dependencies.uniq.sort,
metadata: other_package.metadata
metadata: other_package.metadata,
config: other_package.config
)

ParsePackwerk.write_package_yml!(new_other_package)
Expand Down Expand Up @@ -289,7 +291,8 @@ def self.add_dependency!(pack_name:, dependency_name:)
dependencies: (package.dependencies + [dependency_name]).uniq.sort,
enforce_privacy: package.enforce_privacy,
enforce_dependencies: package.enforce_dependencies,
metadata: package.metadata
metadata: package.metadata,
config: package.config
)
ParsePackwerk.write_package_yml!(new_package)
PackwerkWrapper.validate!
Expand Down Expand Up @@ -370,7 +373,8 @@ def self.create_pack_if_not_exists!(pack_name:, enforce_privacy:, enforce_depend
metadata: {
'owner' => team.nil? ? 'MyTeam' : team.name
},
name: pack_name
name: pack_name,
config: {}
)

ParsePackwerk.write_package_yml!(package)
Expand Down
9 changes: 5 additions & 4 deletions sorbet/rbi/gems/parse_packwerk@0.16.0.rbi → sorbet/rbi/gems/parse_packwerk@0.18.0.rbi
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ def write_package_yml(
dependencies: dependencies,
enforce_dependencies: enforce_dependencies,
enforce_privacy: enforce_privacy,
metadata: metadata
metadata: metadata,
config: {}
)

ParsePackwerk.write_package_yml!(package)
Expand Down
7 changes: 4 additions & 3 deletions spec/use_packs_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ def expect_files_to_not_exist(files)
enforce_privacy: true,
enforce_dependencies: false,
dependencies: [],
metadata: { 'owner' => 'MyTeam' }
metadata: { 'owner' => 'MyTeam' },
config: {}
)

ParsePackwerk.bust_cache!
Expand Down Expand Up @@ -1335,7 +1336,7 @@ def expect_files_to_not_exist(files)
it 'exits in a failure' do
write_file('packs/my_pack/package.yml', <<~CONTENTS)
enforce_privacy: true
enforce_dependnecy: true
enforce_dependencies: true
CONTENTS

write_file('packs/my_pack/package_todo.yml', <<~CONTENTS)
Expand Down Expand Up @@ -1395,7 +1396,7 @@ def expect_files_to_not_exist(files)
end
write_file('packs/my_pack/package.yml', <<~CONTENTS)
enforce_privacy: true
enforce_dependnecy: true
enforce_dependencies: true
CONTENTS

write_file('packs/my_pack/package_todo.yml', <<~CONTENTS)
Expand Down
2 changes: 1 addition & 1 deletion use_packs.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Gem::Specification.new do |spec|
spec.name = 'use_packs'
spec.version = '0.0.10'
spec.version = '0.0.11'
spec.authors = ['Gusto Engineers']
spec.email = ['dev@gusto.com']

Expand Down