Skip to content

Allow use_packs to work without code_ownership configured#77

Merged
alexevanczuk merged 8 commits intomainfrom
ae-gradual-workshop
Mar 30, 2023
Merged

Allow use_packs to work without code_ownership configured#77
alexevanczuk merged 8 commits intomainfrom
ae-gradual-workshop

Conversation

@alexevanczuk
Copy link
Copy Markdown
Contributor

@alexevanczuk alexevanczuk commented Mar 26, 2023

This PR allows use_packs to work in expected ways without the client having configured code_ownership.

Copy link
Copy Markdown
Collaborator

@shageman shageman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shageman
Copy link
Copy Markdown
Collaborator

If you don't install "all the other gems" the added "owner" key fails on not finding the team. We should likely comment out the owner in the config to start

@alexevanczuk alexevanczuk merged commit a024eb1 into main Mar 30, 2023
@alexevanczuk alexevanczuk deleted the ae-gradual-workshop branch March 30, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants