Do not print out red text when a spec cannot be found for a file#88
Merged
alexevanczuk merged 4 commits intomainfrom Apr 19, 2023
Merged
Do not print out red text when a spec cannot be found for a file#88alexevanczuk merged 4 commits intomainfrom
alexevanczuk merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user feedback informed us folks were confused by the red text when a spec was not found, thinking they did something wrong.
99% of the time, a spec simply does not exist, and the user does not need to take action.
For now, we've just changed this behavior. We could always add it back with a
--verbosemode.Separately, I realized that we were not running all tests because of an
exitin the code. I changed internal clients to usesafe_exitwhich I've stubbed across the test suite.