Skip to content

Better lint package YML files#93

Merged
alexevanczuk merged 6 commits intomainfrom
ae-update-lint-package-yml-files
May 17, 2023
Merged

Better lint package YML files#93
alexevanczuk merged 6 commits intomainfrom
ae-update-lint-package-yml-files

Conversation

@alexevanczuk
Copy link
Copy Markdown
Contributor

@alexevanczuk alexevanczuk commented May 16, 2023

This PR updates the behavior for bin/packs lint_package_yml_files to do some extra linting:

  1. It now moves metadata.owner (if it exists) to the top-level owner key.
  2. It sorts top-level keys based on an opinionated/preferred order.

Note that I made a change to parse_packwerk so that now use_packs uses most of the same listing rules as parse_packwerk. That is – lint_package_yml_files isn't doing much since write_package_yml file already does most of the linting work. We might even consider moving the rest of the linting rules that are still in use_packs into write_package_yml!

@alexevanczuk alexevanczuk force-pushed the ae-update-lint-package-yml-files branch from 252f34a to e8161fa Compare May 17, 2023 13:52
@alexevanczuk alexevanczuk merged commit a945b7c into main May 17, 2023
@alexevanczuk alexevanczuk deleted the ae-update-lint-package-yml-files branch May 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant