Improve output when there is an empty package.yml#25
Merged
alexevanczuk merged 5 commits intomainfrom May 1, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up during the RailsConf workshop. A user was seeing the behavior demonstrated in the test written in the first commit.
In this case, the user vendored in their gems in
vendor/bundle, which had this file: https://github.com/Shopify/packwerk/blob/main/test/fixtures/blank/package.ymlThis test fixture from packwerk caused
ParsePackwerkto break when scanning for packages.Before, there would be no helpful output to indicate what file it was failing on, making it harder to adopt.