Don't ignore root package dependencies#13
Merged
alexevanczuk merged 1 commit intomainfrom Apr 9, 2023
Merged
Conversation
alexevanczuk
approved these changes
Apr 9, 2023
alexevanczuk
reviewed
Apr 9, 2023
Contributor
alexevanczuk
left a comment
alexevanczuk
left a comment
There was a problem hiding this comment.
Make sure to bump the version with these PRs so CD works automatically! I just pushed up another commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packs gem underlying this visualization ignores the root package by default (packages are by default only looked for in
packs/*. So, the specific exclusion of the root package is not necessary anymore.Going forward, if you do want to see the root package in your graph, add it to
packs.yml, should it not already be in there ... or vice versa.