Simplify UX#8
Merged
alexevanczuk merged 2 commits intomainfrom Nov 8, 2022
Merged
Conversation
alexevanczuk
force-pushed
the
ae-simplify-api
branch
from
d727786 to
337be77
Compare
alexevanczuk
commented
Nov 8, 2022
| OUTPUT_FILENAME = T.let('packwerk.png'.freeze, String) | ||
|
|
||
| sig { void } | ||
| def initialize |
Contributor
Author
There was a problem hiding this comment.
Before, we tried to color each node based on team owners. This was extra unnecessary complexity and it forced us to raise if there are more than X unique colors.
| nodes_to_draw = graph.nodes.select{|n| node_names.include?(n.name) } | ||
|
|
||
| nodes_to_draw.each do |node| | ||
| next unless highlighted_node_names.any? { |highlighted_node_name| node.depends_on?(highlighted_node_name) } || highlighted_node_names.include?(node.name) |
Contributor
Author
There was a problem hiding this comment.
Before, we showed one level of ancestors and highlighted the given packs.
Instead, we only want to render exactly what the user is passing in. Later, we can think of a way to specify how many levels of ancestors/descendants to render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.